Ryan Blue

Results 205 comments of Ryan Blue

When selecting Cat in your example, we shouldn't create an empty Dog or Turtle, but instead return null because Cat was null. That's why I think we may want to...

Implications in the object model should go in each model. Avro should document that it can't project unless the requested schema includes a NULL branch. However, the overall requirement that...

> Users should be able to project whatever they want and we should not add artificial constraints like this. I think you're right. I wasn't thinking that it was an...

I think it's for the object model to decide how to handle the projection, but that null is a reasonable option. The object model could expose the union as individual...

@dbtsai, the problem with Union is that its behavior isn't well-defined. It is difficult to decide what is correct, and support in processing engines is bad. I don't think it...

Thanks for all the work on this @nezihyigitbasi! I took a close look at this yesterday and I think there are a couple of things we should change. The `VectorizedReader`...

How does this handle nesting? It looks like in `RecordReaderImplementation`, the definition level is checked so you get a vector of nulls and values in the right places, but the...

@wernerdaehn, thanks for working on this. The approach here appears to be to replace nested fields with an ID and then add a list of the circular type to the...

I think there's an easy fix to use sets. If you open a PR, I can merge the fix.

I think this test uses Amazon EC2 instance credentials. You're probably not providing them and that's why it fails.