Ryan Curtin

Results 312 comments of Ryan Curtin

Ack, still haven't had a chance to get to this, but it hasn't fallen off my list entirely...

Thanks @RishabhGarg108. I thought I would get to this before @mlpack-bot closed it last week, but that didn't work out. :) In any case this is pretty close to the...

Ok, managed to open #3093, which will solve this issue. :)

> > Here is a comparison of the Knn master and this PR, just to verify that it does not affect the results. > > In terms of runtime? To...

I think this needs transition to ensmallen before merge, but should be otherwise good to go. :+1:

@zoq what are you thinking for this one? I do think it would be nice to get merged, but not sure how much time you have to work on it.

Hey @zoq, this one got approved a long time ago but not merged---is everything still ready? If so, if you want to merge master in we can go ahead and...

You might need to clean/remove your CMake build directory and reconfigure/rebuild. (There could be an easier way to solve it without nuking the build directory, but, that strategy should work,...

Hey @mercierc, thanks for the contribution! I've kind of hidden from this one a little bit because I don't (yet) know RVMs and it's a big contribution so it takes...

> I noticed that the current conversion enforces C-order whereas CARMA, optionally, enforces F-order as Armadillo is column-major. Actually the reason for this is to match the conventions used in...