Robert C. Seacord

Results 9 issues of Robert C. Seacord

**Describe the bug** Implementation of Rule A1-1-1 only looks for deprecated features and not use of implementation extensions **Expected behavior** ``` // __try // Non-compliant - __try is a part...

Difficulty-Medium
Impact-High
user-report
false positive/false negative

### Affected rules - M2-13-3 ### Description The test here: https://github.com/github/codeql-coding-standards/blob/main/cpp/autosar/test/rules/M2-13-3/test.cpp Is overly simple and fails to test for octal and binary literals, or literals with a type suffix such...

Difficulty-Low
Impact-High
user-report
false positive/false negative

### Affected rules - `A2-5-2` ### Description The checker for "Rule A2-5-2 (required, implementation, automated) Digraphs shall not be used." was not implemented. Presumably, the expectation was that compiler flags...

Difficulty-High
Impact-Low
user-report
false positive/false negative

### Affected rules A8-2-1 ### Description A8-2-1 - “When declaring function templates, the trailing return type syntax shall be used if the return type depends on the type of parameters.”

false positive/false negative

### Affected rules - A7-1-8 ### Description AUTOSAR 19-03 rule A7-1-8 - “A non-type specifier shall be placed before a type specifier in a declaration” is missing and has not...

false positive/false negative

The comments for this test all indicate the first three data structures are classes, while they are clearly structs. https://github.com/github/codeql-coding-standards/blob/bc70b044f71eed50f07a298b69949b7f6c98807b/cpp/autosar/test/rules/A0-1-1/test.cpp#L2

enhancement

There should be a test where the side-effecting and no-side effecting functions are in a different translation unit: https://github.com/github/codeql-coding-standards/blob/9a23abab13bbf3a075dd5f4c1372b93bfcb211e4/cpp/autosar/test/rules/M0-1-9/test.cpp#L1 What is the expected behavior in such as case?

You should add a test for MO-1-2 for a infinite loop that breaks after testing a volatile-qualified object, even if that object is not modified within the loop. This loop...

I tried using this with libc++ and it blew up pretty bad. I'm using _LIBCPP_DEBUG now instead. https://libcxx.llvm.org/DesignDocs/DebugMode.html https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html The following page mentions _LIBCPP_ASSERT but doesn't say you should define...

Product: Compiler Hardening Guide