rcorsi

Results 189 comments of rcorsi

I see another issue #4860 created! Did I do something wrong?!?

> 4860 is this pull request. Issues and pull requests are essentially the same thing in GitHub's backend, just with a different "type". Confusing and counterintuitive, but it's always been...

> @rcorsi the final state of your PR looks reasonable. However like I mentioned, our PR merge workflow ends up cherry-picking PR commits directly onto master. That means all commits...

@ADKaster Thank you for merging, and breaking up the commits into two commits (code and tests). I would have done that, but I misunderstood your comment about that (thought it...

I have a FIXME in the commit changes. I wasn't sure if it was appropriate to call string functions in `UI/AppKit` from `Libraries/LibGfx` This change is the first part of...

@manuel-za wanted to make you aware of this fix. Might impact your testing. I'm wondering if you are looking at the output when using --headless mode? Output from headless might...

OpenSUSE Leap 15.6 gives this output: ``` > ./Meta/ladybird.py run ninja: Entering directory `/home/suseo/projects/myladybird/Build/release' ninja: no work to do. Qt: Session management error: Authentication Rejected, reason : MIT-MAGIC-COOKIE-1 authentication rejected...

Hi @kalenikaliaksandr, what do you think of the updated changes that I made? Is it better? And more generally what do you think of this feature? Boarder line useful or...

Hi @kalenikaliaksandr regarding the SVG issue you mentioned, I tested with my latest commit and I do not see any printouts about falling back to CPU backend when displaying some...