rcorsi
rcorsi
Can this PR be merged, pretty please? It works well and hasn't caused any problems as far as all the tests I ran. We already have All_Debug build steps in...
To get the test-js to complete without issues the #6264 patch has to also be applied.
@awesomekling or @trflynn89 know you guys are really busy, but would you be so kind as to review this change?!
Based on the backtrace, the call to the to_string_without_side_effects() is coming from: ``` Libraries/LibJS/Bytecode/Interpreter.cpp:740 ``` And JS_BYTECODE_DEBUG is the specific debug macro involved in this issue.
@konradekk thank you for your feedback. I'm going to work a little more on it to try to get some actual code examples of the issue. I already found one...
Running test-js with the new is_cell() check in the latest commit provides the name of the classes at the source of this issue. Here are the log counts of the...
I did some digging and found these four internal objects when running the test-web program. ``` CompletionCell DeclarativeEnvironment GeneratorResult PromiseCapability ``` I can see that CompletionCell and GeneratorResult work together...
@gmta Could you please have a look at this PR to give me some feedback. There is this issue and a new one I just opened #6948 that are detected...
> @rcorsi Not sure why you are pinging me? We have #code-review or #js on Discord to try to get the attention of maintainers. I'm not particularly knowledgeable in this...
linter found that I had a blank line at end of TestLibCoreMimeType.cpp, removed it and pushed