Robert Chen

Results 74 comments of Robert Chen

> And was the fix associated with this patch already available in develop? Yes, it was this commit https://github.com/LLNL/RAJA/pull/1311#issuecomment-1214202533, which was created after the v2022.03.0 release in develop. It seemed...

@davidbeckingsale The HIP DESUL tests keep timing out for some reason. Should I increase the job length, or is this not expected to happen?

@rhornung67 @davidbeckingsale This finally passed, would you mind approving so we can merge?

@rhornung67 @davidbeckingsale Approve again? Thanks!

> @rchen20 did the change make it into develop? There is nothing in the changes here except for documentation. Nevermind. I see your earlier comment. David is out until 10/3....

I'll try this with XL because that's usually the most problematic compiler.

Strange, I'm running in to 2 different compilation issues with test-forall-atomic-basic-OpenMP.exe. One is the excessive recursion on our templating (saw this in https://github.com/LLNL/RAJA/pull/1165), the other is the camp::resources::Omp not found...

Adding `-DCAMP_ENABLE_TARGET_OPENMP` looks like it's helping; I'm just waiting for XL to build it . . . Once that's confirmed to work, I'll put a PR up. Still not sure...

Indeed, I'm looking in to that option!

Thanks @davidbeckingsale, that worked for the clang-omptarget tests. Still waiting on XL to see if the test works, but made a PR for this anyway because we should have it...