Christian Di Lorenzo

Results 14 comments of Christian Di Lorenzo

@MaxPleaner This would go in your `:addict` config in the `config.exs`.

Since this would be a larger task, I'd like to see what the interest is from others. **Please give a thumbs up if you see this thread and would use...

Sounds awesome! I do really need to revisit the code in this repository since I've learned a lot since I first started it. Inline docs and cleaner code would be...

Quick question. Did you check out the demo or just use the README when you found this repo? I'm just wondering how helpful the demo is to others.

When you say a "blank value" do you mean an empty string or `nil`? I like this proposal but want to make sure I understand for sure beforehand.

So, does `parse_params` actually throw an error if you pass an empty string or did you mean your application logic rejects it since it is then filtering using that blank...

Oh, I see. Yes, I like this! What do you think about calling it `ignore_empty` versus `ignore_blanks`? I'm not sure myself and wonder how those strike you.

I agree. Let's go with `ignore_blanks` then and have that match `""` and `nil`.

Yes. That sounds good with one minor tweak on the names. Let's use `Filtrex.Encoders.Fragment` and `Filtrex.Encoders.Map` to reduce some verbosity. That means they would go in `lib/encoders/fragment.ex` and `lib/encoders/map.ex` respectively.

@gen1321 Ah, I hadn't thought about that. 🤔 I think we'll probably have to have a module that allows you to define your own type that uses a hardcoded configuration...