Ron Buckton
Ron Buckton
> Additionally, anything can use `Symbol.hasInstance` to lie, so it's generally not a good tool to reach for. I don't think that's relevant, the same thing applies to `Symbol.customMatcher`.
> In the example, we have > > ```js > class Book { > constructor({ > // ... > // Extract `createdAt` as an Instant > createdAt: InstantExtractor(createdAt) = Temporal.Now.instant(),...
For an example of consistency, you can roughly emulate extractors in an _AssignmentPattern_ (but not a _BindingPattern_) with some convoluted code: ```js let x1, y1, x2, y2; // using extractors...
That's a fair point. The less you need to override in the eslint configuration, the better.
I imagine there's a number of ways to address this in Node. For example: Given that its the REPL and almost guaranteed to have a developer actively interacting with the...
@bergus is correct. Exceptions thrown from dispose generally should indicate a serious problem (i.e., failure to close a file handle, failure to commit or rollback a database transaction, etc.) and...
I would also add to @bakkot's example with something just as reusable as @bergus's example, but without mutating the resource: ```js function tryDispose(obj) { try { obj?.[Symbol.dispose](); } catch {}...
@rwaldron > (IMO, `:` is the best of the two) However, in light of the "slice notation" proposal, this becomes ambiguous: `o[3:px]`. I do kind of like `'` as an...
@eps1lon do the latest changes satisfy your review feedback?