Ron Buckton comments

Results 538 comments of


                                            Ron Buckton

[WIP] Disallow merging of `enum` declarations

@typescript-bot test top1000

[WIP] Disallow merging of `enum` declarations

@typescript-bot test top999

Ensure that Comparers only return -1, 0, 1 so results can be equated

I've always wondered why we use `Comparison` rather than just `number` and do `< 0`/`> 0`/`=== 0`. Is there a performance benefit to using one or the other?

Ensure that Comparers only return -1, 0, 1 so results can be equated

> I also noticed (but did not change) the fact that we use binary searches for things like import insertion with the assumption that the input is always sorted, but,...

Ensure that Comparers only return -1, 0, 1 so results can be equated

> > While they may be "sorted" in one respect, you cannot always safely use them as an argument that accepts a "sorted" array without also providing the comparer that...

Incorrect emit for parameter properties when using standard class fields

We've done a similar transformation in the past, such as we do for `accessor` fields. I don't think this transform would have any major issues, as the only side effects...

[explicit-resource-management] Add remaining tests specific to using statement semantics

Thanks @arai-a, should be fixed now.

[explicit-resource-management] Add remaining tests specific to `await using` statement semantics

Thanks @arai-a, should be fixed now.