Evan Baker
Evan Baker
@wenhuwang I think you are right. We do some `platform` manipulation with buildx to cross compile and make the ARM images from an AMD64 host and an arch reference has...
This sounds reasonable to me. Maybe every occurence of `--platform=` should be `$TARGETPLATFORM` _except_ the one where we are compiling the Go binaries? In that one, it's much faster to...
@MiteshJalan please amend your commit message to conform to [ConventionalCommits](https://www.conventionalcommits.org/), sign it, and add signed-off-by (`git commit --amend -S -s` to do it all in one step)
@hainenber thanks for picking this up, I'll give this a thorough review ASAP. One initial question - I noticed in the [GH sample workflow they don't have any explicit keys](https://github.com/actions/starter-workflows/blob/main/ci/docker-publish.yml#L90-L98)....
I did some experimenting with this and I couldn't quite get it to work: https://github.com/rbtr/retina/actions/runs/8474428281 Here are the changes I made: https://github.com/rbtr/retina/commit/04c7fe61670c2360ddef030054ad5e099ebbde1b Ran in to a few problems: - the...
> Thanks for your effort on testing out the changes on your forked repo! My apologies for having this under the radar as I tend to disable GH actions in...
thanks @hainenber! I will test this out 🙂
Hey @hainenber if you will resolve conflicts and sign, then I think we can get this merged
Thanks @hainenber! Sorry one last thing - we require all commits to be cryptographically signed. I think maybe you had done this, but it was lost during an update. Can...
> I always sign off my commits by default though. Do I miss something? > [...] > Edit: Hmm, they're no longer verified. Let me re-sign them for that Right,...