retina icon indicating copy to clipboard operation
retina copied to clipboard

chore(*): replace discontinued github.com/golang/mock with actively maintained go.uber.org/mock

Open hainenber opened this issue 1 year ago • 2 comments

Description

  • Replace discontinued golang/mock with a more actively maintained go.uber.org/mock.
  • Add a missing refererence for generated go-generated mock file.

Related Issue

N/A

Checklist

  • [x] I have read the contributing documantation.
  • [x] I signed and signed-off the commits (git commit -S -s ...)
  • [x] I have correctly attributed the author(s) of the code.
  • [x] I have tested the changes locally.
  • [x] I have followed the project's style guidelines.
  • [ ] I have updated the documentation, if necessary.
  • [ ] I have added tests, if applicable.

Screenshots (if applicable)

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

hainenber avatar Mar 28 '24 16:03 hainenber

@hainenber btw, the fmter most of us use is https://github.com/mvdan/gofumpt, which I believe does this by default

timraymond avatar Mar 28 '24 17:03 timraymond

Fixed. Turns out I ran gci on the whole codebase instead of changed files :D

hainenber avatar Mar 28 '24 17:03 hainenber

Hey @hainenber if you will resolve conflicts and sign, then I think we can get this merged

rbtr avatar Apr 01 '24 17:04 rbtr

merge conflict resolved :D

hainenber avatar Apr 01 '24 17:04 hainenber

Thanks @hainenber! Sorry one last thing - we require all commits to be cryptographically signed. I think maybe you had done this, but it was lost during an update. Can you re-sign them?

rbtr avatar Apr 01 '24 17:04 rbtr

I always sign off my commits by default though. Do I miss something?

image

Edit: Hmm, they're no longer verified. Let me re-sign them for that

hainenber avatar Apr 01 '24 17:04 hainenber

I always sign off my commits by default though. Do I miss something? [...] Edit: Hmm, they're no longer verified. Let me re-sign them for that

Right, you've got the Signed-off-By already. But this is the extra bit I'm looking for: image

This is a merge requirement given the low-level access that Retina has to the hosts 🙂

I opened #197 for improving our docs about this but it hasn't been picked up yet

rbtr avatar Apr 01 '24 17:04 rbtr

Could be something I could work on as well :D

Anyhow, the commits are now signed with my key :D

hainenber avatar Apr 01 '24 17:04 hainenber