René Brunner
René Brunner
@moneromooo-monero wrote: > I've not finished reviewing, but reading your coments and the zeroed timestamps makes me think that maybe it'd be both simpler and working in every case to...
Today I started to implement @moneromooo-monero 's approach, with a single `std::deque` containing both added and removed txs. I quickly saw that it's not as easy as at first sight,...
I made code changes for the issues pointed out by @moneromooo-monero today. I became aware that several PRs are currently on the way that will change the minor RPC version...
I tried to reproduce the error in the functional tests after building that GitHub documents [here](https://github.com/monero-project/monero/runs/4635592269?check_suite_focus=true) but failed, i.e. the "mining" functional tests ran through on my machine without any...
Thanks @j-berman for reviewing! Can you tell me when you are through so I can look at everything and improve in one go? TIA. One advance general comment: There are...
About your re-visit of @moneromooo-monero 's alternative storage proposal: Presented this way, that array looks like a protocol of adds and removes to the pool. This looks indeed like very...
The crux is that the longer you look the more aspects come to light :) When I first mentioned to implement this on IRC @hyc voted to implement the necessary...
> I imagine you're going to want to keep as is now :) I try to find a suitable balance between my lazyness and the undisputed right of the dev...
I rebased to current master, incremented the minor daemon RPC version from 9 to 10, and implemented a proposal resulting from @j-berman 's review to re-use a method after making...
I just pushed an update with significant improvements of the code based on valuable review suggestions from @j-berman. I hope they will find time to re-review this update soon to...