rbrugaro

Results 14 comments of rbrugaro

I have the same question. I think [run_controller](https://github.com/All-Hands-AI/OpenHands/blob/fc4ad2f8c3719190c957f92093a201032389b09f/openhands/core/main.py#L52) intends to support passing a runtime but actually [main](https://github.com/All-Hands-AI/OpenHands/blob/fc4ad2f8c3719190c957f92093a201032389b09f/openhands/core/main.py#L289) does not use it. I am also using the [cli.py](https://github.com/All-Hands-AI/OpenHands/blob/main/openhands/core/cli.py) and that one...

> The `-n` parameter is only for the conversation, not runtime, indeed. _Edited to add_: Also, it works for headless, but not for CLI. [This PR](https://github.com/All-Hands-AI/OpenHands/pull/8431) makes it work for...

I am also experiencing this. I have checked the provided `save_trajectory_path` and the `openhands-state` folders but sessions are not saved. I am using `-n sessionName` and it is saving sessions...

I think might be a permission error between the userid and the folder ownership. Setting `FILE_STORE_PATH` i get a permission error. `An error occurred: [Errno 13] Permission denied: '/.openhands-state'` In...

Thx @mamoodi, I found my prior sessions at `/tmp/openhands_file_store/sessions` That was the default setting up to [0.40](https://github.com/All-Hands-AI/OpenHands/blob/3fe4434c22ee2fd92527844a58569034847ef760/openhands/core/config/app_config.py#L64) when there was still an app_config.py and switched in [0.41](https://github.com/All-Hands-AI/OpenHands/blob/2cea1461fb648850697c30d10acc3b736820e147/openhands/core/config/openhands_config.py#L67) to '~/.openhands/file_store'

@mkbhanda yes we can find better names. My reasoning is the G in RAG implies llm generation and highlights retrieval of some sort is used.. we could do retrieval based...

@jiqing-feng @sywangyi I updated code to read world_size and rank from environment variables and set good default settings only if unset by user. 50% oob improvement in generation time in...

@sywangyi @jiqing-feng Turned out to be a bug in accelerate that was setting the wrong `num_cpu_threads_per_process` when the script was launched with `accelerate launch myscript.py` because it was reading an...

@sywangyi @jiqing-feng @echarlaix I have addressed the comments and accelerate [PR#3009](https://github.com/huggingface/accelerate/pull/3009) has been merged. please review