Robert Brennan comments

Results 1267 comments of


                                            Robert Brennan

Add 'produces' key to responses.

Thanks for the contribution! It looks like this breaks the tests though. Can you take a look by running `WRITE_GOLDEN=true npm test`?

References not working?

I haven't been able to verify yet - still on the old version

Generate prometheus metrics

Agreed - definitely a big lift to get something log lived in the cluster. IMO it's probably out of scope for this project, but I'm open to it. Maybe we...

[stable/fairwinds-insights] Add proper resource requests and limits option for overprovisioning

Right--I'm suggesting that requests should always be equal to limits. So we only need one memory/CPU option in the values.yaml

[stable/vpa] keep admissionController.cleanupOnDelete when admissionController ena…

@yasinlachiny there's something wrong with CircleCI. We're gonna get in touch with their support team

VPA TargetRef created can be considered invalid by K8s Autoscaler Recommender

Yeah exactly - I think adding some options to controller-utils is the way to go

Integrate kube-capacity for cluster summary

A few more things we could track in a summary at the top of the page: * \# of workloads with too much cpu/mem * \# of workloads with too...

bump rss-parser and express to latest

We're still using `parseString`, which was removed from the latest `rss-parser`. You also need to update `package-lock.json` in order for the tests to pass.

Set response schemas in project's openapi.json

[Relevant FIXME](https://github.com/DataFire/DataFire/blob/master/src/util/openapi.js#L193)

Add support for data diffing

I've been talking with another integration provider about how best to go about this. Each service will probably have a unique way of pushing new items and changes to items....