[stable/vpa] keep admissionController.cleanupOnDelete when admissionController ena…

[yasinlachiny]

Why This PR? I want to keep admissionController.cleanupOnDelete when admissionController enable: false And for general use cases if we can enable each admissionController separately that would be great. and for the special my use case I want to upgrade form fairwinds/vpa chart_version=1.1.0 to chart_version=1.4.0 and it will remove admission-controller-cleanup but I don't want to delete it and there is no way to keep it. If I want to keep it I have to use

admissionController:
  enabled: true

and it will enable a lot more things.

Fixes #

Changes Changes proposed in this pull request:

Checklist:

• [x] I have included the name of the chart in the title of this PR in square brackets i.e. [stable/vpa].
• [x] I have updated the chart version in Chart.yaml following Semantic Versioning.
• [x] Any new values are backwards compatible and/or have sensible default.
• [x] Any new values have been added to the README for the Chart, or helm-docs --sort-values-order=file has been run for the charts that support it.

[CLAassistant]

All committers have signed the CLA.

[sudermanjr]

Hi there! Thanks for the contribution!

Can you please add some clarification to the PR text describing the desired use-case for this? I think I can see it, but want to make sure we're on the same page.

Additionally, a quick look at this tells me it's likely going to be simpler and easier to understand if we just remove the or and execute this hook if admissionController.cleanupOnDelete is set to true. What are your thoughts?

[yasinlachiny]

Hi @sudermanjr

Thanks a lot for your quick response. I removed the or and execute hook just by admissionController.cleanupOnDelete That's absolutely better.

[sudermanjr]

Thanks for the quick update! Can you please sign the CLA? In the meantime, I'm trying to figure out what's wrong with our CI

[yasinlachiny]

Hi @sudermanjr Could you please run the CI pipeline again? Thanks in advance.

[rbren]

@yasinlachiny there's something wrong with CircleCI. We're gonna get in touch with their support team

[sudermanjr]

@yasinlachiny can you please sign the CLA?

[yasinlachiny]

Hi @sudermanjr I signed the CLA issue. I used my other email address and it created a problem for CLA and I corrected it.

[yasinlachiny]

@sudermanjr Just a friendly reminder :))

[yasinlachiny]

@sudermanjr Just a friendly reminder :))

[yasinlachiny]

Hi @vitorvezani @transient1 @sudermanjr Could you please check my last changes? I bumped the version based on master branch