Robertino Bogart

Results 13 comments of Robertino Bogart

@Ronimsenn , The issue is that `poetry add` performs validation on the project name, while `poetry init` does not. This allows a project with characters like `+` in the name...

Thanks! I'll work on it and post back here when its ready for review.

Hi @Ronimsenn , I could use some guidance on where best to place project name validation. The regex for project names already exists in `poetry-core` inside [project-schema.json](https://github.com/python-poetry/poetry-core/blob/002aa3e16f98d21645bb9a45f698b55adc40f317/src/poetry/core/json/schemas/project-schema.json#L10C1-L14C7), and is used...

Thanks for the input @Ronimsenn ! No worries at all. @radoering , would you like to share an opinion on this?

@radoering , I just tested this out and it looks like it will work. Thanks for suggesting it! In addition to validating the project name, it also validates all other...

@radoering @Ronimsenn , I opened a PR for this. Sorcery-ai pointed out that I didn't add an integration test for this change. I tried to write an integration test for...

@radoering and @Ronimsenn , this is ready for review! https://github.com/python-poetry/poetry/pull/10457

@radoering , I tired `Factory.validate()` directly, but it appears to modify some global state and it caused several unrelated tests to break. Initializing a `Factory` instance first and then calling...

This is no longer needed. Its been replaced with [this](https://github.com/python-poetry/poetry/pull/10457) PR, which has the same code changes, but with a cleaned up commit history.

@radoering , @yuji38kwmt , @python-poetry/triage, if this issue hasn't been addressed yet, I would be interested in working on it!