Razvan Deaconescu
Razvan Deaconescu
@ggracechoi , could you update your PR based on @StefanJum 's comments? And also rebase it to fix the merge conflicts.
> Looks good, @ahmd-kamel please also squash the commits. @ahmd-kamel , could you please squash the commits according to feedback from @StefanJum ?
@ahmd-kamel , could you check the comments from @RaduNichita ?
@ggracechoi , could you please follow @StefanJum 's advice and update your PR?
> This looks fine @dorjoy03, but I would go a bit further and replace all `*alloc` calls with the equivalent `uk_*alloc` call. That will mean also replacing the `free` calls...
> > This looks fine @dorjoy03, but I would go a bit further and replace all `*alloc` calls with the equivalent `uk_*alloc` call. That will mean also replacing the `free`...
@dorjoy03 , we're aiming to have this PR part of the next release (planned for the end of August). Could you please make updates to the PR by then? Or...
@razvanrus2003 , could you check @StefanJum 's comments?
@keenox , could you please see @skuenzer 's comments?
@keenox , could youe please update your PR to fix the merge conflicts?