Razvan Deaconescu
Razvan Deaconescu
@kha-dinh , any reason for closing this?
Hi, @zhxj9823, this is marked as draft work. What needs to happen to make this a full PR?
@GrubFe , thanks for the PR. Could you please add the rationale behind the fix (noted in the description changes) in your commit message? See the [contributor guidelines](https://unikraft.org/docs/contributing/unikraft) as well.
@GrubFe , could you please rebase this PR?
@arvganesh , could you please see @nderjung 's comments?
Hi, @pranjalrai4 , sure, go for it.
@pranjalrai4 , it's only for that instance. You define the `LIBVFSCORE_INITRD_OPT_MKMP` macro and assign it to the "mkmp" string. Then, instead of using the "mkmp" string int that one instance,...
@ggracechoi , amend your commit to follow the [contributing guidelines](https://unikraft.org/docs/contributing/unikraft). See [this tutorial on amending commits](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message). For running checkpatch locally, follow [these instructions](https://unikraft.org/docs/contributing/testing#using-checkpatchuk).
@YuanSamuel , could you please update this PR to include the feedback from @nderjung ?
@YuanSamuel , could you please update your PR to consider @nderjung 's comments?