Ray Bell
Ray Bell
`_check_identical_xr_types` is likely to get added in #277. Should help with this issue
You know how to upload to zendo? I got as far as here. I took a look at https://zenodo.org/record/5038065#.YQiYLVNKh6o
cheers. Looks like it needs a release to push
on zenedo now. +1 on JOSS paper. I'm happy for whoever writes it to be lead author.
> Who would be a co-author? Everyone in https://github.com/xarray-contrib/xskillscore/graphs/contributors? Would say the core devs: you, me, Riley, Dougie
> What would be the criterion? More than one/5 feature/PRs merged? I think we can filter people > 1 PR (edited). So the author list can be: Spring (assuming you...
Thanks @aaronspring. I think it meets the requirements. Worth adding it's domain agnostic e.g. https://xskillscore.readthedocs.io/en/stable/tabular-data.html. The accessor method allows it to be dropped in a pandas/scikit-learn workflow on tabular data....
> also all the testing code is very much the same. here we could use fixtures and parametrizatsions even more Yeah especially https://github.com/raybellwaves/xskillscore/blob/master/xskillscore/tests/test_np_deterministic.py
slightly related comment at the top here (https://github.com/xarray-contrib/xskillscore/pull/247#issuecomment-761953050)
I'm in favor of well named test files which are clearly defined with and built with hierarchy. For example currently we have: - https://github.com/xarray-contrib/xskillscore/blob/master/xskillscore/tests/test_metric_results_accurate.py which checks the math of the...