rayane-d
rayane-d
@FitseTLT @huult Could you please update your proposals based on this?
> @rayane-djouah What do you think about https://github.com/Expensify/App/issues/52413#issuecomment-2472472338? @huult I have concerns about adding another Onyx storage entry; I think it could be more complex than necessary and might impact...
> @rayane-djouah BTW I misunderstood the expected behaviour yesterday if it is to save the changes then my previous proposal was already aligned to it so I have reverted [back](https://github.com/Expensify/App/issues/52413#issuecomment-2471245417)...
@FitseTLT, using > if (transactionBackup) { > Onyx.set(`${isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, transactionBackup); > return; > } is duplicating code from `TransactionEdit.restoreOriginalTransactionFromBackup`. To address the root cause of the bug,...
@FitseTLT, could you update your proposal based on [this feedback](https://github.com/Expensify/App/issues/52413#issuecomment-2513234960)?
@nyomanjyotisa removing `setHighlightedIndex(skinToneEmoji.skinTone)` will cause a bug: | Before removing `setHighlightedIndex(skinToneEmoji.skinTone)` | After removing `setHighlightedIndex(skinToneEmoji.skinTone)` | | ------------- | ------------- | | | |
> ### What alternative solutions did you explore? (Optional) > Or set the highlightedIndex with the new currentSkinTone.skinTone > > ``` > useEffect(() => { > setHighlightedIndex(currentSkinTone.skinTone); > }, [currentSkinTone]);...
@nyomanjyotisa's [proposal](https://github.com/Expensify/App/issues/52918#issuecomment-2491843872) looks good to me :ribbon::eyes::ribbon: C+ reviewed
### BugZero Checklist: - [x] Classify the bug: Bug classification Source of bug: - [ ] 1a. Result of the original design (eg. a case wasn't considered) - [x] 1b....