rayane-d
rayane-d
Reviewing proposals...
@ahmedGaber93 The root cause in your [proposal](https://github.com/Expensify/App/issues/39305#issuecomment-2027885209) is incorrect; we don't use `PersonalDetailsUtils.getDisplayNameOrDefault` when determining a report's name. I also tried your suggested changes, but they didn't fix the bug.
@nkdengineer, you've identified the correct root cause in your [proposal](https://github.com/Expensify/App/issues/39305#issuecomment-2027909014) and suggested changing LGTM. It uses the same approach as we are doing with the last message text in LHN...
@nkdengineer please let us know your ETA
@nkdengineer we agreed on the main solution in your proposal https://github.com/Expensify/App/issues/39305#issuecomment-2042786695, didn't we? I see that the PR is implementing the alternative one.
@anmurali, @thienlnam, we need clarification about the expected result when the user sends a message that contains "@expensify.sms" (not necessarily a mention); as seen in the screenshot below, currently, we...
Asked in [Slack](https://expensify.slack.com/archives/C01GTK53T8Q/p1712885174171229?thread_ts=1712093926.089859&cid=C01GTK53T8Q)
@nkdengineer, we got an answer in [Slack](https://expensify.slack.com/archives/C01GTK53T8Q/p1712885174171229?thread_ts=1712093926.089859&cid=C01GTK53T8Q); we should implement your main solution.
Deployed to production https://github.com/Expensify/App/pull/39994#issuecomment-2069779658
@anmurali, please remove the Reviewing label and bump to Daily as payment is due