Ravishankar Sivasubramaniam comments

Repositories
Issues
Comments

Results 4 comments of


                                            Ravishankar Sivasubramaniam

🐛 Fix `alias` support for Pydantic v2

@YuriiMotov @svlandeg I’ve addressed all the comments from the review. Let me know if there’s anything else you’d like me to focus on.

🐛 Fix `alias` support for Pydantic v2

@YuriiMotov I have made changes based on your suggestion. schema_extra. Precedence is: explicit params > schema_extra > alias propagation. In v1, using these keys raises a RuntimeError. No warnings added....

🐛 Fix `alias` support for Pydantic v2

> The idea looks good to me! > > A couple of more things: > > * I think it would be nice to use `alias` as a default value...

`Field(alias="")` doesn't work with Pydantic V2

@YuriiMotov @svlandeg Hi! I've attempted to create a fix for this issue in **PR #1577**: https://github.com/fastapi/sqlmodel/pull/1577 I hope this approach helps address the problem where `Field(alias="...")` wasn't working as expected...