Ravi Kumar Mandala
Ravi Kumar Mandala
@cavecafe This should be fixed now. I am requesting a release with this fix in https://github.com/google/EarlGrey/issues/1483. Vote on it with more details on how it might help you.
This issue is fixed. It can be closed now.
Also created this - https://bazel-review.googlesource.com/c/tulsi/+/89190
Thanks to @ob for chipping in for this change. @DavidGoldman @dierksen Can you please take a look at this? \cc @reinhillmann
@dierksen I simplified the location expansion logic as per your suggestion. Also modified the `.gitignore` to exclude Tulsi's own Xcode project files and tulsi-workspace symlink. Please take a look.
@DavidGoldman, @ob has an example in https://github.com/bazelbuild/bazel/issues/7083 in the form of a `repro.sh` to reproduce this issue. Does that help with integration test?
@DavidGoldman, Can you please take a look?
[Gentle reminder] @dierksen, @DavidGoldman - can you please review the changes? TIA.
Ahh, now I see what you mean. Let me add a test for this feature.
@DavidGoldman, we have a PR, that's coming right up, to expand location using `ctx.expand_location()` in `tulsi_aspects.bzl` so that Xcode sees expanded header map paths instead of split up opts/attrs.