raven_dev comments

Results 4 comments of


                                            raven_dev

fix(polyfill): missing self argument for Watcher notify callback type

Addtionally to typing, `this` and `self` seem to be passed wrong. ```js const w = new Signal.subtle.Watcher(function (self) { console.log(this === w); console.log(this instanceof Signal.subtle.Watcher); // both false; same with...

Signal Forms Optional Fields - Nullability

I believe this would very much apply to any optional/clearable non-string values.

Not able to return MenuItem[] through a function to model attribute in SplitButton component.

SplitButton uses TieredMenu under the hood. For MenuItems containing `routerLink`-property will create an Angular RouterLink. But since the Stackblitz Example has no Angular Router Setup, it will throw a Dependency...

Not able to return MenuItem[] through a function to model attribute in SplitButton component.

That's actually a seperate issue due to ChangeDetection and Re-Rendering: Zone.js triggers ChangeDetection on almost any Events or Event-Listeners regarding HTML-Elements. TieredMenuSub has internal actions on hover: https://github.com/primefaces/primeng/blob/c903ce36b661327ce076fbbe2442c8ad6197e47f/packages/primeng/src/tieredmenu/tieredmenu.ts#L363 Which in...