Kirill Agalakov

Results 173 comments of Kirill Agalakov

The errors are also unconditionally logged during tests where I expect components to throw and catch the errors myself with error boundaries. This is frustrating and pollutes test output.

Hey folks, I'm running into exactly the same issue. I'm building a custom server on top of esbuild and struggling with injecting extracted css files into to the output html....

@klimashkin Unfortunately I don't have enough practice with innerRef/withRef because, well, I just don't use it. But anyway, why can't we just pass actual ref prop through all the hocs?...

@klimashkin I see. Do you suggest reverting replacement of `withRef` with `innerRef` or do you have some more elegant solution?

I don't believe that introduction of a new convention looks like a solution but still I agree that innerRef could be reverted back to withRef at least to be similar...

I need some time to actualize tests and migrate to latest TS 2.4.1

I think it would also be nice to update the rest of the docs including new features: nested themes, theme spreads etc.

@artem-popov The problem with namespaces is that `themr` relies on the fact that classname string starts with namespace and checks it with `startsWith`. But actual classname construction is controlled by...

I don't see any problem with HOC's: you can still split HOC's styles and its child styles into different files and combine them into one theme object using `themeable` and...

@artem-popov What's more many devs use react and themr with typescript and namespaces break possibility to check the type of theme received in props because actual keys differ from defined...