Alex Rattray

Results 414 comments of Alex Rattray

thanks for the suggestion/contribution, this change has been incorporated!

Thanks for reporting, we'll take a look.

I haven't looked into this PR in depth, but in case it's useful, I wrote a simple algorithm to gauge expression complexity in another branch: https://github.com/rattrayalex/prettier/blob/postfix-ternaries/src/language-js/utils/index.js#L622-L647

@SimenB or other maintainers – would a PR implementing this proposal be welcome?

Hi, sorry we haven't been able to get to the bottom of this yet. The repro steps you've provided look helpful, so I hope we'll be able to fix this...

I definitely agree this is not a good situation. It is essentially a Sentry bug, and the [workaround is documented in associated GitHub issue on their package](https://github.com/getsentry/sentry-javascript/issues/12414#issuecomment-2272789736): > The workaround...

Actually, I'll keep this issue open until the next major version, as a reminder to double-check that it does indeed resolve this problem.

@jreidgreer can you share a stackblitz or equivalent that reproduces the bug?

Thanks for reporting. I believe `.on('error', cb)` should actually work, but doesn't appeared to be typed/documented appropriately. We'll look into this.

Thanks for the PR! We hope to take a look soon – sorry for the delay.