Alex Rattray

Results 272 comments of Alex Rattray

Actually I'm going to reopen this because while there is a workaround, I agree that our defaults should be better and I'd like to track that. cc @RobertCraigie

If there is a response header `retry-after: 5`, for example, this library will wait 5 seconds before retry. Note there's also `retry-after-ms: 4321` which would wait 4.321 seconds. In case...

It's this code: ```py max_retries = options.get_max_retries(self.max_retries) # If the API asks us to wait a certain amount of time (and it's a reasonable amount), just do what it says....

😄 thanks Mike! I really appreciate the kind words. Just to be clear, you're saying that you prefer the behavior in #9559 to either of the behaviors in this proposal...

Thanks for the real-world examples, Mike! I decided to peel off the last one and see how they compare. Turns out Option A would be the exact same as indented,...

Thanks @roryokane for reviving @0x24a537r9 idea (and @zeorin for putting up the earlier PR). I'll admit I had overlooked this approach, and seeing the examples and advantages spelled out by...

Exploring TS Conditional Types specifically with this format, I wonder if we could special-case things to get a nice blend of Option A and Option B2, in the spirit of...

Whether or not Option B2 is adapted to turn into Option A for some TS Conditional Types, I basically agree that B2 seems very likely to be strictly superior to...