Ross Smith II

Results 268 comments of Ross Smith II

@AtomToast Good point. I haven't tested it, but the `env.` logic is the same as the other `yadm.` so I am really surprised it's not working. See https://github.com/TheLocehiliosan/yadm/blob/0a5e7aa353621bd28a289a50c0f0d61462b18c76/yadm#L426-L431

@AtomToast You are correct. Just below https://github.com/TheLocehiliosan/yadm/blob/0a5e7aa353621bd28a289a50c0f0d61462b18c76/yadm#L439-L444 we need to add ``` for (label in ENVIRON) { value = ENVIRON[label] pattern = sprintf("%s%s|", pattern, condition_helper(label, value)); } ```

@AtomToast No sorry, I haven't. Hopefully @TheLocehiliosan can un-stale this, as I can't.

Another option would be: ``` charset = utf-8 charset = utf-8-bom ``` which would work well with other tools, such as vscode. They would presumably ignore the second entry.

Since the spec allows for additional keys, perhaps: ``` charset = utf-8 charsets = utf-8,utf-8-bom ``` addresses this issue the best, while being compatible with other tools.

> [@rasa](https://github.com/rasa) as you've implemented that feature ... any idea what the issue might be? @mstruebing No, only: @hongbo-miao Are you sure you are using 3.6.0? The ``` Wrong character...

https://github.com/cmldk/HumanizeDuration.js provides relative time. If internationalization is needed, perhaps the easiest way would be to merge this fork's changes into https://github.com/rasa/HumanizeDuration.js, though I haven't looked into how easy that would...

I've done a fair amount of work on this, but so far, not much progress. I'll commit what I've done, so others can provide feedback. node dependency wrangling is not...

FontAwesome is only used by strelaypoolsrv. We could replace it with forkAwesome, but that package is deprecated, where FontAwesome is still active.

> We already have a knob to disable this, for approximately this reason. Would it make sense to just use that instead? That's true, but it may not be that...