Ross Smith II

@klaernie Good feedback. I thought of that too. But what led me to think `latin1` means ISO-8859-1 is https://github.com/editorconfig/editorconfig/wiki/Character-Set-Support which links `latin1` to https://en.wikipedia.org/wiki/ISO/IEC_8859-1 . That page says it's "Latin...

Note, I had to add `"application/octet-stream",` to [validation.go](https://github.com/rasa/editorconfig-checker/blob/rs/support-charset-setting/pkg/validation/validation.go#L25)'s `textRegexes` list, for things to work as expected. Now it's in sync (again) with [pkg/config/config.go](https://github.com/rasa/editorconfig-checker/blob/6f1c4bc95712e3b8f4045bafca7661520e9b59db/pkg/config/config.go#L72). I'm not sure how things worked without...

> So we should implement `latin1` as strictly ISO-8859-1, and not support any of the other ISO-8859-* variants for now, as the editorconfig itself does not list them as supported....

I think the test files at https://github.com/arthenica/libiconv/tree/master/tests and https://github.com/pa-0/dos2unix/tree/master/dos2unix/test may be of higher quality, so I am thinking of adding them to our testdata. If code review hasn't started, lemme...

The code I believe is production ready, but I'm converting to draft to revision the test framework, and explore using snapshots, as @klaernie suggested. Please be patient as I haven't...

> Hey @rasa any progress on this? @mstruebing No, sorry. I haven't looked into snapshots, which I think is a good idea. And reducing the number of test files probably...

I rebased main onto this PR. I am going to change it to "Ready for review", as it is production ready, and so, it could be merged as is. But...

This is still an issue with 1.74. Perhaps it's just my machine, but please consider accepting this PR, as it can't hurt, and can only help others like me. Thanks.

/verify

@Fredolx Checkver is failing. Please advise. Thx.