Renato Arruda

Results 15 comments of Renato Arruda

@duboisf : Anything I can do to help to get this merged? I would love to be able to use it in linux (and i could use a custom build...

Given that fluent-bit [1.9.7 got released](https://github.com/fluent/fluent-bit/releases/tag/v1.9.7) with the relevant code change in place, it might be worth while considering merging this documentation PR as well. @lecaros @nokute78

It should now support compression (as of 1.9.7 IIRC), but the PR for documenting the feature has not been approved/merged yet.

The (currently unmerged) PR with the documentation on how to enable compression can be found at: https://github.com/fluent/fluent-bit-docs/pull/824

@april4 Short answer: yes, compress is now supported in the elasticsearch output. See https://docs.fluentbit.io/manual/v/2.0-pre/pipeline/outputs/elasticsearch and compress parameter on how to configure it in the latest version of fluentbit.

This is awesome work! But as early feedback, these are my initial thoughts: should we consider having: 1. one Gem, which a configurable engine parameter, where one could toggle between...

After looking extremely superficially at the PR: - code coverage is not so important as an absolute metric with such a refactor. Totally ok to just ignore it in this...

shutdown is meant as the clean shutdown method, and shutdown! As the unclean version of it. The idea of saving in the clean shutdown/way, so if it does get restarted...

> > Most likely it's a corner case that few will meet. > It would happen in some race condition where the thread that would write to disk is not...

Actually this was reported in issue #33 and implemented in PR #40