Mikola Parfenyuck

Results 19 comments of Mikola Parfenyuck

Also solution on python https://github.com/aspectumapp/osm2geojson

In code we are working with multipolygons (in general case). It possible to detect polygons (and convert) in function `multipolygon_relation_to_shape` after line 482 https://github.com/aspectumapp/osm2geojson/blob/068b83afe19cff1ae15b9efc2a9ff5a9be8928e7/osm2geojson/main.py#L482 but I see that `mapping` function...

yes, I need more details to understand problem with right-hand rule. Maybe this line can be helpful for you (unfortunately I don't remember the purpose of it) https://github.com/aspectumapp/osm2geojson/blob/master/osm2geojson/main.py#L222

So what about this now? It should be easy to return Polygons in `json2shapes` and `xml2shapes` methods (here example https://github.com/aspectumapp/osm2geojson/blob/return-polygon-shape/osm2geojson/main.py#L483). But this is also breaking change

Hi. I tested your example (`besseringen.txt`) and looks like no problem. ![image](https://user-images.githubusercontent.com/5012778/149839219-f211eea5-b639-4c5b-869c-e072aef05bb7.png) Maybe I can find problem when you provide full example of your code and query/data.

@eseglem Thank you for your work (and code example provided)! I made a few changes in your code and added test for this bug.

@eseglem Here release with that change https://pypi.org/project/osm2geojson/0.2.1/. Thank you for noticing that problem with github actions. I think it's because of different shapely version (I have older on my computer)....

Ok, I'll take a look on that tomorrow. But I need this 'empty' example (you can send me whole XML/JSON content from Overpass)

@eseglem I hope this fix https://github.com/aspectumapp/osm2geojson/commit/024c06b099bc41a0c734d8435c048116c2cc3055 should help with your problem (it still may not work with other examples, becuase this solution doesn't look reliable). I read that code in...