Raphael Raph Carvalho

Results 234 comments of Raphael Raph Carvalho

Fast streaming for intra-node migration is completed. @tgrabiec please consider pulling it into your branch: https://github.com/tgrabiec/scylla/pull/1

On Sun, May 5, 2024, 9:59 AM Avi Kivity ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In replica/table.cc > : > > > @@...

> > On Sun, May 5, 2024, 9:59 AM Avi Kivity _**@**_._**> wrote: _**@**_.**_* commented on this pull request. ------------------------------ In replica/table.cc : > @@ -106,11 +106,6 @@ table::make_sstable_reader(schema_ptr s,...

> #### 🔴 CI State: FAILURE > ✅ - [Build](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/8557/) ✅ - [Container Test](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/8557/) ✅ - [dtest](https://jenkins.scylladb.com/job/scylla-master/job/gating-dtest-release/9418/) ❌ - [dtest with topology changes](https://jenkins.scylladb.com/job/scylla-master/job/gating-dtest-release-with-consistent-topology-changes/1396/) ✅ - [Unit Tests](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/8557/) > > ####...

v2: - instead exclude tablets in tablet set that don't intersect with range of read. previous approach breaks interaction of compound set and incremental selector. It's safer to restrict change...

to fix clang-tidy issue, will have to rebase once https://github.com/scylladb/scylladb/pull/18596 lands on master

v4: - incremental_selector::select(const dht::ring_position_view&) is moved to header - pass selector_pos to incremental_selector_impl::select() as const ref.

> It might not be obvious after reading the discussion, so I'd like to note that the regression reported in this issue is a regression of the raft-based topology compared...