Raphael Raph Carvalho
Raphael Raph Carvalho
> Where's the extracted fix? I assume we should merge it first? Oops, missed ur question. Yes, it should be merged first. Extracting it now and will open a GH...
> Looks good, I left a couple of questions. > > What about backlog computations? I think they need to be done per compaction group now (and summed to get...
> > Where's the extracted fix? I assume we should merge it first? > > Oops, missed ur question. Yes, it should be merged first. Extracting it now and will...
Test Result (2 failures / ±0) test_topology.test_remove_node_add_column non-boost tests.test_topology.release.2415 @kbr- does it ring a bell to you?
> We suspect this PR will fix it: #11691 It's currently in review. thanks.
v2: - table no longer have access to compaction_group private namespace - fixed scylla-gdb memtables - fast path in table::apply(const frozen_mutation& m, ...) if single group, to avoid unnecessary token...
> CI state **`FAILURE`** - https://jenkins.scylladb.com/job/releng/job/Scylla-CI/1897/ Failed due to a flakiness in test/raft/randomized_nemesis_test. Already reported to raft devs.
Successful run: https://jenkins.scylladb.com/job/releng/job/Scylla-CI/1916/ The flakiness is tracked here https://github.com/scylladb/scylladb/issues/11288 and unrelated to this work.
v3: - rebased - split preparatory changes for unit tests - moved compaction_group into its dedicated header - added noexcept qualified to methods retrieving sstable set in compaction_group - moved...