Raphael Valdetaro

Results 6 comments of Raphael Valdetaro

@edwinjosechittilappilly yes , i tested It.

> Very nice improvements @raphaelchristi , thank you! > > EDIT: @raphaelchristi i just realized, i dont think the DropdownInput supports multi-select... Thanks @erichare That's a good point... Which input...

> Mypy failures are the main thing here. Thanks for the review @erichare ! I checked the mypy linting and it's passing without any issues now. ![image](https://github.com/user-attachments/assets/9493bf1d-fbb2-40e6-9387-9ae902089495)

> What are the advantages of using a StrInput over a MultilineInput for this case? The main reason for using `StrInput` instead of `MultilineInput` is that both provide the same...

> @raphaelchristi it looks like some unit tests are failing still. I think this is a good addition... let me know if you have a chance to take a look....

Hi @ogabrielluiz , Thank you for the review! I've implemented the suggested changes: - Converted all methods to async using async/await - Added asynccontextmanager for the tmpdir operations - Implemented...