Raphaël Proust
Raphaël Proust
IIUC this MR has the same aim as https://github.com/ocsigen/lwt/pull/967 I don't have time rn to review either. I'll try to do it soon.
related pointers: - https://github.com/ocsigen/lwt/issues/897 - https://github.com/ocsigen/lwt/pull/961
The CI fails with ``` 2023-07-17 09:53.52: No .ocamlformat file found 2023-07-17 09:53.55: Job failed: No opam files found! ``` I'm guessing the first one is a warning (rather than...
(I don't use github much (outside of the maintenance on this and one other repo) so I don't necessarily have the whole context for the actions and such. Still here...
Thanks a lot for the MR. I don't have a windows machine to test this on so I can't reproduce locally. Nevertheless, I'll be reviewing this MR soon.
> i dunno if you can get CI to run on the first diff I don't know either. I don't understand github's UI very well. :question: :exclamation: But that's ok....
At first I was pleased that the code was so similar. Then I thought it'd be even better if the code was even more similar. And then I started thinking...
A similar situation happened on the eio bugtracker: https://github.com/ocaml-multicore/eio/pull/352#discussion_r1037282020 It's not exactly the same (not the same code being copied, not the same size of code) but it's also copying...
I've made https://github.com/raphael-proust/ocaml/commit/bdbddd2c25687c1bf658be6835f8b12b0c99704d which aims to expose the code that we actually need from the OCaml source. Please leave comments on there, I don't know that I did anything correctly.
As per https://github.com/ocaml/ocaml/pull/12492#issuecomment-1728049155 it turns out licensing is not an issue. We can go ahead on this PR.