Raphaël Proust
Raphaël Proust
The git commit does fail when the hook exits with non-zero. The issue is with the feedback to the person editing the wiki: there isn't any. The page is not...
I'll check if it's a version thing. Or if I need to pipe the message to stdin rather than stderr in the hook. Will report back in a bit.
It'd be useful to be able to deactivate syntax highlighting. I've never found a convincing simultaneous use of diff-highlighting and syntax-highlighting: there are always corner cases when the one makes...
What does that do to the cone of dependency of Lwt? What does alcotest depend on? I'm quite reluctant to add dependencies to Lwt in general. I'm ok with some...
> "dune" {>= "2.8"} > "ocaml" {>= "4.05.0"} > "fmt" {>= "0.8.7"} > "astring" > "cmdliner" {>= "1.0.0" & < "1.1.0"} > "re" {>= "1.7.2"} > "stdlib-shims" > "uutf" {>=...
I'm not sure all the functions in this module should return promises which are rejected by an exception. I think it might be interesting for users to still recover the...
That gets us half of the way there… but it still breaks backwards compatibility. Another possible approach is to deprecate the use of `timeout` and recommend `Lwt_unix.with_timeout` instead. The function...
We might break a few packages by making this breaking change, but we should be able to propose patches to either use `with_timeout` or add version constraints (in case the...
It'd probably need to be a separate function for backwards compatibility. It'd also need to be a different function to allow for the convenience of getting the results in a...
Thanks for the comment. The timing is what is giving me the most doubts and I'm happy to have a more concrete example to check. I'll have a look at...