Kohei Taniguchi

Thank you for your consideration! I want to suggest one more addition for the signature. I think it is better to make it returns `Vec` not `BigInt`. Because it is...

@omershlo Hi, I updated this PR. Could you check the changes, please?

You mean it should use below way which using BigInt to create slice for the hash function? ```rust let message_len_bits = message.len() * 8; let R = local_ephemeral_key.y.bytes_compressed_to_big_int(); let X...

Thanks, you wonder about extracting `compute_e` function, right? > Your code create a function compute_e that should be created each time differently for different argument - so I cannot take...

No problem. Thank you for explanation of your policy. I understand. > So that, how about getting compute_e function back into each protocol file? So, what do you think about...

Ok, i will go ahead. By this changes, there are two same implementation for computing e. But it is temporary. I think bitcoin_schnorr.rs's one should be changed for to adapt...

I can show 2 points which should be adapted. 1. Compute e from only x coordinate of two public key. current implementation includes prefix which represents y coordinate. 2. Decide...

Thank you for your response. I understood the way to use the hash function correctly. How about this part. https://github.com/KZen-networks/multi-party-schnorr/blob/master/src/protocols/thresholdsig/bitcoin_schnorr.rs#L188 When creating localsig, it converts message bytes array to BigInt....

Thank you for the information. I read it and I could understand probably ;) Your libraries assume that the message inputted to computing signature function is hashed value. However, I...

Thank you! Can I try to create a PR for this issue? I think there are 2 way to fix. 1. Use other hash function like sha2 crate. 2. Create...