Andrea Canciani

Results 120 comments of Andrea Canciani

@AndriySvyryd I see that in some cases the `testDirectory` is empty, but apparently in other cases ("efcore-ci (Build {Linux,Windows,macOS}") it can really run, at lease according to the results from...

The current state of the PR is that: - 40d7aa7f40844f5762d31b6ed117f1d2e86c1ca5 fails (see https://dev.azure.com/dnceng-public/public/_build/results?buildId=724842&view=results) as expected (aka the tests are run) - 4a928374540448e58dd5a5008a50ef63d0a542b1 passes them (see https://dev.azure.com/dnceng-public/public/_build/results?buildId=724854&view=results and/or the checks on...

I updated the code to throw an `AggregateException` that combines all of the exceptions. Regarding changing the reading/writing of the baselines, I am afraid it would be a more invasive...

As mentioned in https://github.com/dotnet/efcore/issues/29624#issuecomment-2182047136 this is still WIP (opened as PR for viewing convenience @roji ).

I will work more on this in the weekend. ⚠️ This changeset might cause is a significant reduction in the test coverage for `RewriteNullSemantics`. Will think about this in the...

I added the checks for SQLite version >= 3.8.11 and SqlServer CompatibilityVersion >= 160 Several tests are failing on SqlServer: - Compare_negated_bool_with_negated_bool_equal - Compare_bool_with_negated_bool_not_equal - Compare_negated_bool_with_bool_not_equal - Compare_negated_bool_with_bool_equal_negated - Compare_negated_bool_with_negated_bool_not_equal...

I pushed a commit that avoids using `IS [NOT] DISTINCT FROM` when that would trigger #34001. Obviously it would still be desirable to (also) fix #34001

As an intermediate step, I opened #34072 which adds exhaustive testing of the null rewriting (plus some cleanup/minor improvements ;) ). My current plan would be to run this test...

I rebased this PR to resolve conflicts and to start getting to the issues that have been reported: - [x] rename `IsExpression` to `IsNotDistinctFromExpression` or `IsDistinctFromExpression`; I would like to...

Rebased to solve conflicts and keep an eye on SQL Server updates in CI 😉 This is currently on top of https://github.com/dotnet/efcore/pull/34166 which affects the translation of boolean comparisons