Andrea Canciani

There is a further constraint around `NULL` values which cannot be noticed while filtering, but would affect projection Assuming that `Url` is not nullable, the following query ```sql SELECT "b"."BlogId",...

> Shouldn't the optimization simply collect all WHEN blocks with the specific value, and string them together with ORs? In other words: > > ```sql > CASE > WHEN x...

> Can you provide an example for this? At least in the above example, if none of the conditions hold, the CASE/WHEN would return NULL, and the simplification should return...

> BTW an unrelated note: I'm not sure why the optimization is limited to constants only - it seems we could widen it to arbitrary SqlExpressions (though keep in mind...

fun fact: while trying to write the test cases in https://github.com/ranma42/efcore/tree/fix-case-when-9 I hit another (apparently unrelated) issue around nullability 😅 EDIT: posted the issue as #33752

> > If we want to transform it, it should get simplified to x OR (NOT(y) AND z), i.e. > > You're absolutely right, we indeed can't ignore WHENs with...

If it makes sense to you I would 1. open a PR based that fixes this issue by removing the incorrect optimization and extending the CompareTo one a little bit,...

This is an attempt at making the CI hit the same issue as https://github.com/dotnet/efcore/issues/22901#issuecomment-2194172006 Locally I bisected the regression as follows: ``` $ git bisect log # bad: [1847e1e9e0bde22a70a2c9388d9e9e36c6d9842d] Simplify...

The regression noticed by @ErikEJ and @cincuranet is apparently caused by a bad interaction between the introduction of the `Uri.Equals(Uri)` method in https://github.com/dotnet/runtime/commit/94bb125fe98955a26fc3f96c13a2c3bf52cc46bd and https://github.com/dotnet/efcore/blob/main/src/EFCore/ChangeTracking/ValueComparer%60.cs#L140-L176 Currently EFCore 1. prefers the...

This PR makes it possible to run the compiled model tests in CI and updates the baselines. I will push a PR that simplifies the generated model in the next...