David Ramos comments

Results 148 comments of


                                            David Ramos

Is there a reason so many interfaces accept `String` instead of `&str`?

I think this is over-optimization and not worth the time and effort, especially with the breaking changes that would be involved. I'm unlikely to merge these sorts of changes, just...

Axum example

Sounds good! I'll try to find some time to review it if you submit a PR adding the contributed example link.

OpenTelemetry Tracing API vs Tokio-Tracing API for Distributed Tracing

> I am partial towards Option 2. Specifically I don't think we'd eliminate the API surface as we're currently supporting basically all the needed features in the spec. As a...

`typ` validation in JWT JOSE header

Hey, thanks for starting this discussion. Out of curiosity, what `typ` value(s) are you seeing in the wild that are causing issues with this crate? The `typ` header specifies the...

`typ` validation in JWT JOSE header

> This is also the reason why I started with implementing Option 3 to easily check for other `typ` values. That makes sense. Since the proposed changes are to the...

`typ` validation in JWT JOSE header

~Done in #175~

Use `Into<String>` or `ToString::to_string` rather than requiring owned `Strings` up front.

See ramosbugs/oauth2-rs#248. I'd be open to the constructor methods accepting `impl Into` in both crates for better ergonomics.

add From<&str> implementation for types using `deserialize_from_str!`

Thanks for the PR! I'm generally wary of `From` since it encourages stringly-typed code that can lead to bugs in user code. For example, consider a function: ```rust fn foo(client_id:...

add From<&str> implementation for types using `deserialize_from_str!`

I would just add a generic doc message like "Construct a new ``" No need to reference the specs, which I think would be more appropriate in the type's top-level...

Hey @avtrujillo, I'll probably stabilize 4.0 soon after stabilizing [oauth2](https://github.com/ramosbugs/oauth2-rs) 5.0. Since both of these versions had major breaking changes, I'd like to wait another couple of months to see...