Ramon

Results 176 comments of Ramon

Thanks for testing and the great questions @andrewserong > One subtle thing I noticed in the UI is that it doesn't expose the size controls by default when the theme.json...

> I'll check, but I'm going to guess "yes", the resolved path is saved. @andrewserong Just checked and my guess was half right 😄 Top-level raw theme.json values are not...

> If we want to make sure that style variation relative paths are saved in the database, then I think image resolution will have to happen, as mentioned above, when...

> > nested theme.json styles > When you say nested theme.json styles, do you mean theme style variations? Ah no, pardon my sloppy language, and thanks for clarifying. I meant...

> If so, I wonder if there's a way to preserve the reference to the theme URL instead of "baking" in the URL in the user global styles data Firstly,...

I appreciate the test @andrewserong Apologies it's so huge - it's turning into another proof of concept PR, so it's ripe to be broke up once I get feedback from...

> would it be worth pinging in the WP Slack core-restapi channel for feedback, or if this is the preferred way forward, opening a trac ticket for the REST API...

> We already have the convention of using file:./path/to/file.ext for settings.typography.fontFamilies.fontFace.src. Would it make sense to use file:./ prefix for styles.background.backgroundImage.url as well, when using an image bundled with the...

> Since paths are always relative to the theme root, and theme.json might be in a style variation (styles/variation.json), can we avoid prefixing the paths with . Also asked on...

> Code looking good! There's two things I'd like us to address in follow ups: Thank you! I'll chase those two points up, ~~and also rename `set-theme-file-uris.js` more appropriately~~ done