Ramon
Ramon
Thanks for the reviews @ntsekouras and @aaronrobertshaw 🙇 I've committed your suggestions.
> Just a note that with the spacing presets we went with the format 2XL instead of XXL, but mainly because the range of options is wider, eg. can go...
> Let's just see how it looks once the spacing sizes UI is merged. 💥
> The XXL name doesn't show up unless I add "name": "Extra Extra Large", manually. I shouldn't have to, right? Hmmm, so long as there are five presets it doesn't...
> Forgive me I'm not sure I understand. Just to be clear, so long as you have 5 size presets or less, the should map to the segmented control. And...
> This slug (name) is used to apply appropriate classnames, CSS var strings in the form of var:preset|color|${ slug }, and create the actual CSS vars themselves. Given that, duplicate...
Resolved by https://github.com/WordPress/gutenberg/pull/43496
Thanks for the ping @ndiego > This is a major change, that I don't think should be considered for inclusion in 6.3 now that we are past Beta 1. +1...
> This is an important change, but it's also a tough one to test because it touches so much. I think we need to start looking at it early if...
@scruffian @MaggieCabrera If you need help moving this one forward, I'm happy to rebase and test, and tinker with it. I'll take it for a spin next week. If there...