rami3l

Results 461 comments of rami3l

@Veetaha Sorry for the confusion. I did a throughout review of what happened and decided to stick to the new behavior. I have updated the comment accordingly. 🙇

@joshtriplett Thanks for your feedback! I do think we can always inject `?search=` at the end of the URL assuming the page is almost always `mdbook` or `rustdoc`-based. https://github.com/rust-lang/rustup/pull/4070 should...

> How would it know which document to search for File? Or would it always just assume std? Or would it search all docs. But then how? @ChrisDenton That's not...

> So: if the user types File then search doc_root/std/**/*.File.html? @ChrisDenton I still doubt whether we should do a FS-level search by ourselves since having to search in a range...

@ChrisDenton #4069 asks for the `broken_intra_doc_links` _anchor_ in `--rustdoc`, and currently that would be `rustup doc --rustdoc lints::broken_intra_doc_links`. If, like you've said, for the positional arg it's limited to file...

@ChrisDenton Yeah, so I think we can very much suggest the search feature via a note if the navigation fails (and thus ensuring the discoverability) rather than actually doing the...

@djc Yup, I agree with prettier as well, since it has a pretty sane default config.

> I'd strongly recommend adding roll back process for when a deployment causes failure like what happened in 1.28.0. @joshka I second this. In fact, I [have already mentioned it...

> Using a toolchain while components are being installed is tricky because it involves modifying the toolchain directory. Rustup is not currently safe for that kind of thing. Though I...

Note: Some say we're not doing well enough in terms of speed, see #2626.