rustup icon indicating copy to clipboard operation
rustup copied to clipboard

Consider introducing an HTML and CSS formatter for the Rustup website

Open 0xPoe opened this issue 1 year ago • 2 comments

Problem you are trying to solve

As dicsusued in https://github.com/rust-lang/rustup/pull/4080#issuecomment-2481060171 and https://github.com/rust-lang/rustup/pull/4080#issuecomment-2485247199.

I think it would be a good idea to introduce a formatter for this. It would help us avoid similar situations in the future. I’d recommend using Prettier, but it does require adding a new toolchain, such as npm, pnpm, or yarn, to install it. What are your thoughts on this?

Solution you'd like

  1. Install the prettier
  2. Format the project using the default configuration.

Notes

No response

0xPoe avatar Nov 19 '24 11:11 0xPoe

I think it would be a good idea to introduce a formatter for this. It would help us avoid similar situations in the future. I’d recommend using Prettier, but it does require adding a new toolchain, such as npm, pnpm, or yarn, to install it. What are your thoughts on this?

I think the most important factor is that we can easily deploy something into CI. Beyond that, having plugins for common editors (like VS Code) might be a nice to have. I don't have a good sense of the landscape here, Prettier seems okay to me.

djc avatar Nov 19 '24 12:11 djc

@djc Yup, I agree with prettier as well, since it has a pretty sane default config.

rami3l avatar Nov 30 '24 01:11 rami3l