Ramesh Singh

Results 8 comments of Ramesh Singh

> Fixes [vector-im/element-web#23837](https://github.com/vector-im/element-web/issues/23837) I have sent PR(https://github.com/matrix-org/matrix-js-sdk/pull/3345#issue-1698769126), please review it

![Screenshot from 2023-05-23 23-00-44](https://github.com/matrix-org/matrix-react-sdk/assets/115406405/3c5bda49-15e5-4cc7-b679-1fb70f6337db)

> @rameshsinghppc are you still keen to work on this? If you need pointers on how to fix up the CI failures then let us know. @richvdh Yes, please help...

> > @richvdh Yes, please help me to fix these failures. > > Ok, what have you tried so far and which parts are confusing you? I don't know how...

> > Right; a lot of the problem here is that it is building against your fork of `matrix-js-sdk` (https://github.com/rameshsinghppc/matrix-js-sdk) which is outdated. (We have some magical branch matching.) You...

> @rameshsinghppc once you have made some changes you think will fix the CI please say so in a comment. @richvdh No sir, It's contributor's responsibility to resolve all the...

@richvdh Few days back I made some changes in the code, please re- run the CI.

@richvdh Today I have updated the code with eslint and test cases passed. Please re-run the CI. ![Screenshot from 2023-06-13 22-43-49](https://github.com/matrix-org/matrix-react-sdk/assets/115406405/95651203-7c56-4475-8e2b-f63e8669e522) ![Screenshot from 2023-06-13 22-43-30](https://github.com/matrix-org/matrix-react-sdk/assets/115406405/fafc25f0-06fb-44b5-805c-8c7ecc660e84)