rameshraghupathy
rameshraghupathy
> I have several general comments on the design: > > 1. There is no definition of all CLI commands that should be used to control the DPUs. > 2....
Hi Mana, Alarm and Syslog remain the same and there won't be new functions.
> Summary seems to be having a typo? Is it: "Added support to enable chassisd from the platform, which is necessary for SmartSwitch"? Done
Created https://github.com/sonic-net/sonic-buildimage/pull/19729 and addressed these comments in https://github.com/sonic-net/sonic-buildimage/pull/19729. #18676 18676 was created using the 202311 branch which is not where the smartswitch changes are applied.
> Can you please add UT for the new functions? Done
> What are the states supported by the DPUs in the Smart Switch? ”dpu_midplane_link_state” ”dpu_control_plane_state" "dpu_data_plane_state"
The following 4 PRs have been raised for PMON Platform Independent changes: https://github.com/sonic-net/sonic-buildimage/pull/18676 https://github.com/sonic-net/sonic-platform-daemons/pull/467 https://github.com/sonic-net/sonic-platform-common/pull/454 https://github.com/sonic-net/sonic-utilities/pull/3271