Richard McHale

Results 9 comments of Richard McHale

For now I'm working round this by using ``

Merged in the latest version, and switched from Flash Vectors to Haxe Arrays.

Thanks for the work on resolve the underlying changes @gsteel I've just done a quick rebase and fixed a few obvious bits. Busy day ahead, so I'll get back to...

Awesome work @gsteel ! Aside from squashing the commits, no. I think anything else can be a seperate PR

> Spotted a few nitpicks Thanks. I'll pick most of those up tomorrow

Thanks @arhimede My focus at the moment is on compatibility with the newer service-manager. My planned next steps at the moment are - ~~Replace unit test mocks of ValidatorChain with...

In the meantime is it worth adding a warning to Translator? Something like ``` if (isset($options['cache'])) { if ($options['cache'] instanceof CacheStorage) { $translator->setCache($options['cache']); } else { trigger_error('Constructing the cache in...

@microsoft-github-policy-service agree

Hi I mainly raised this to get some feedback from the CI pipeline about where the issues are with this upgrade, but it appears that the CI run isn't kicking...