Julien Ramboz
Julien Ramboz
> In helix-markup.yaml configure img tags to be replaced with esi:include tags that use I don't think this would work, I'd be surprised if the "expansion" library we use to...
Performance comparison: At first glance, there is no noticeable impact. Plugin version is even slightly faster, but that is likely just the variance in the test
@kptdobe Shall I also port this over to aem-lib? Or should we first validate and discuss the approach here for a bit?
@kptdobe Agree on all point! And yes, the foo/bar stuff are just examples. I'll work on creating a cleaner demo, so it's easier to read
@kptdobe All done. PR should be cleaner now and the project-level logic is now in a separate repo. I initially also wanted to move the page loading logic into the...
@davidnuescheler @rofe @kptdobe @fkakatie Would love to have your thoughts on the current proposal to see how to fine-tune this.
And we also agreed to remove the `this` context hack on proper functions in favor of a more consistent use of the `context` last parameter on the main exports
[WIP] Follow-up PRs: - https://github.com/adobe/aem-lib/pull/23 - https://github.com/adobe/aem-boilerplate/pull/275
@rofe We've tried it on a dozen websites so far, and it's working fine. But I remember discussions with @trieloff to try to simplify this and leverage more the `CustomEvent`...
Closing in favor of #374