Rajesh Chinnam

Results 5 comments of Rajesh Chinnam

sure @ketkarameya I will be waiting for your response one more scenario I have my method public String get(String requestNumberPrefix, String request) { if (tenantConfiguration.get(TenantConfigurationKey.FEATURE_SEQUENTIAL_NUMBERS_FOR_WARRANTY).equals("true")) { log.info("request number prefix is...

@ketkarameya can you please let me know what could be the issue here when you get some time.

Thanks @ketkarameya Please refer https://github.com/rajeshchinnam/piranha/blob/main/feature_flag_cleanup.py https://github.com/rajeshchinnam/piranha/blob/main/configurations/rules.toml I can able to fix the rule and I am trying to fix another use case https://github.com/rajeshchinnam/piranha/tree/main/configurations eg: I want to remove the test...

@ketkarameya Please review my updated rule https://github.com/rajeshchinnam/piranha/blob/main/configurations/rules.toml **remove_method_with_specific_line : is updating when(TenantConfiguration.get(TenantConfigurationKey.FEATURE_SEQUENTIAL_NUMBERS_FOR_WARRANTY)).thenReturn("false");** as **when("true").thenReturn("false");** https://github.com/rajeshchinnam/piranha/blob/main/src/main/java/com/piranha/DocumentInfoServiceTest.java and my rule is https://github.com/rajeshchinnam/piranha/blob/main/configurations/rules.toml when i am testing this on play sitter its matching...

I fixed it @ketkarameya