Stanley Winata
Stanley Winata
Can we add mlir-opt + FileCheck test to ensure that the conversion is doing exactly what we want? not just for this pass but for all the future passes, I...
For 3. I think we then need to change the default of `--repro_dir` in shark/parser.py
@AmosLewis can you check why the tests are failing?
Ahhh, I think he was still using an older venv when pushing up these changes "local-sync', 'local-task" did not exist when he was trying it out on his local machine.
@shikhar13012001 Thanks in advance for the contributions! I have assigned this issue to you :)
How the whole test looks like, if we specify do not specify any device: Still retains specifying device capability/ -k "":
I added the parameterization of static/dynamic, although it did make it more complex since we need to do outerproduct to get all of the devices/staticity combinations. As well as a...
ahh I added it, however the error still seem to persist 😅
@benvanik I was wondering if you can point to where the fences are being called in vulkan, we may be missing some implementation for our [LevelZero HAL](https://github.com/raikonenfnu/iree/tree/ze-shark-09-19-2022/experimental/level_zero), is [this](https://github.com/raikonenfnu/iree/blob/ze-shark-09-19-2022/experimental/level_zero/direct_command_buffer.c#L158-L174) still...
@benvanik unfortunately I was able to find iree_hal_semaphore_list_wait on waits, iree_hal_semaphore_list_signal on the queue method. I was wondering if after this change(hiding semaphore), we would need the a device-based semaphore...